Skip to content

Update coding standard from PSR-2 to PSR-12#141

Open
jlnarvaez wants to merge 5 commits into
AdobeDocs:mainfrom
jlnarvaez:patch-2
Open

Update coding standard from PSR-2 to PSR-12#141
jlnarvaez wants to merge 5 commits into
AdobeDocs:mainfrom
jlnarvaez:patch-2

Conversation

@jlnarvaez

@jlnarvaez jlnarvaez commented Apr 10, 2023 •
edited by jeff-matthews
Loading

Copy link
Copy Markdown
Contributor

Purpose of this pull request

This pull request (PR) updates PSR-2 to PSR-12 that is a extended version of deprecated PSR-2.
Extracted from official documentation:

Deprecated - As of 2019-08-10 PSR-2 has been marked as deprecated. PSR-12 is now recommended as an alternative.

Affected pages

Links to Magento Open Source code

jeff-matthews
jeff-matthews reviewed Apr 12, 2023
View reviewed changes

@jeff-matthews jeff-matthews left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jlnarvaez, but there's already a PR open for this update that I'm trying to validate with internal teams (#92).

@jeff-matthews

jeff-matthews commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

Actually, I'm going to reopen your PR @jlnarvaez because you've signed the Adobe CLA and the contributor who opened #92 has not.

@jeff-matthews jeff-matthews reopened this Apr 12, 2023
@jeff-matthews jeff-matthews self-assigned this Apr 12, 2023
@jeff-matthews

jeff-matthews commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

Need to wait for the PR in the coding standards repo to be merged before updating docs.

magento/magento-coding-standard#416

@jeff-matthews jeff-matthews added the content-quality Language, formatting, SEO metadata, authoring standards compliance label Apr 12, 2023
@jeff-matthews jeff-matthews mentioned this pull request Apr 17, 2023
Merged
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🔍 Linter Report

Click to expand full report 
═══════════════════════════════════════════════════════════════
                     LINTER REPORT
═══════════════════════════════════════════════════════════════

Generated: 2026-06-15T23:32:31.376Z
Mode: Full Linting (all rules + dead links check)
Target Directory: /home/runner/work/commerce-php/commerce-php
Skipped Rules:
  - check-frontmatter → src/pages/includes

───────────────────────────────────────────────────────────────

Files to process: 1


═══════════════════════════════════════════════════════════════
                        SUMMARY
═══════════════════════════════════════════════════════════════

  📁 Files processed:    1
  📄 Files with issues:  0
  ❌ Total errors:       0
  ⚠️  Total warnings:     0
  📋 Total issues:       0

Result: ✅ PASSED - All files passed linting successfully!

═══════════════════════════════════════════════════════════════

This comment was automatically generated by the linter bot.

@dshevtsov dshevtsov added technical Updates to the code or processes that alter the technical content of the doc and removed content-quality Language, formatting, SEO metadata, authoring standards compliance labels Jun 16, 2026
@dshevtsov dshevtsov self-assigned this Jun 16, 2026
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🔍 Linter Report

Click to expand full report 
═══════════════════════════════════════════════════════════════
                     LINTER REPORT
═══════════════════════════════════════════════════════════════

Generated: 2026-06-16T17:09:05.908Z
Mode: Full Linting (all rules + dead links check)
Target Directory: /home/runner/work/commerce-php/commerce-php
Skipped Rules:
  - check-frontmatter → src/pages/includes

───────────────────────────────────────────────────────────────

Files to process: 1


═══════════════════════════════════════════════════════════════
                        SUMMARY
═══════════════════════════════════════════════════════════════

  📁 Files processed:    1
  📄 Files with issues:  0
  ❌ Total errors:       0
  ⚠️  Total warnings:     0
  📋 Total issues:       0

Result: ✅ PASSED - All files passed linting successfully!

═══════════════════════════════════════════════════════════════

This comment was automatically generated by the linter bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeff-matthews jeff-matthews jeff-matthews left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@dshevtsov dshevtsov

Labels

technical Updates to the code or processes that alter the technical content of the doc

Projects

Commerce - Pull Requests
Status: 🧊 On Hold

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jlnarvaez @jeff-matthews @dshevtsov